Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make Popover implement HasAriaLabel, add overlayRole #6425

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

web-padawan
Copy link
Member

Description

Based on vaadin/web-components#7446

Type of change

  • Feature

@web-padawan web-padawan force-pushed the feat/popover-aria-properties branch from 09d1cb4 to 9be0cc0 Compare July 10, 2024 07:15
Copy link

sonarcloud bot commented Jul 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
21.3% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@web-padawan web-padawan removed the request for review from DiegoCardoso July 10, 2024 07:32
@web-padawan web-padawan merged commit 345e518 into main Jul 10, 2024
4 of 5 checks passed
@web-padawan web-padawan deleted the feat/popover-aria-properties branch July 10, 2024 07:33
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants